CLDR-16900 Fix bugs in the previous PR #3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Check whether user is logged in before calling schedule.tooSoon -When the Announcements page gets opened, fetch immediately, since previous fetch only set unread count -New method cldrSchedule.reset facilitates immediate re-fetch -In cldrSchedule.tooSoon return false if this.lastRequestTime is zero (reset or not yet set) -Comments
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
srl295
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Check whether user is logged in before calling schedule.tooSoon
-When the Announcements page gets opened, fetch immediately, since previous fetch only set unread count
-New method cldrSchedule.reset facilitates immediate re-fetch
-In cldrSchedule.tooSoon return false if this.lastRequestTime is zero (reset or not yet set)
-Comments
CLDR-16900
ALLOW_MANY_COMMITS=true